Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for -Wstrict-prototypes #1729

Merged
merged 3 commits into from Oct 21, 2022

Conversation

DavisVaughan
Copy link
Member

As requested by CRAN in the email about slider:

* checking whether package 'slider' can be installed ... [5s/5s] WARNING
Found the following significant warnings:
  /home/Hornik/lib/R/Library/4.3/x86_64-linux-gnu/vctrs/include/vctrs.h:12:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
  init.c:69:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
  init.c:72:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
  slider-vctrs-private.c:12:6: warning: function declaration isn't a prototype [-Wstrict-prototypes]
  /home/Hornik/lib/R/Library/4.3/x86_64-linux-gnu/vctrs/include/vctrs.c:7:6: warning: function declaration isn't a prototype [-Wstrict-prototypes]
  slider-vctrs-public.c:3:6: warning: function declaration isn't a prototype [-Wstrict-prototypes]
  summary-core.h:9:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
  summary-core.h:10:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]

Not all yours: can you pls liaise with the vctrs maintainer?

@DavisVaughan
Copy link
Member Author

When this PR is used in combination with an updated rlang C library (after r-lib/rlang#1508 is merged), vctrs is now quiet

@lionel- lionel- merged commit 7e0150f into r-lib:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants