Update complex tests #1883
Merged
Update complex tests #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed because of changes in R-devel, where
as.complex(NA/NA_real_/NA_integer_)now all return0in theIm()slot (since no logical/double/integer conversion to complex can ever make an imaginary value). This is used byrlang::cpl()andvec_coerce_bare(), the latter of which we should probably drop eventually in favor of our own custom conversion routines for complex, but not nowhttps://stat.ethz.ch/pipermail/r-devel/2023-September/082864.html
wch/r-source@1a2aea9