Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try using bindtextdomain() for cache clearing #183

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Try using bindtextdomain() for cache clearing #183

merged 4 commits into from
Jan 9, 2024

Conversation

hadley
Copy link
Member

@hadley hadley commented Nov 7, 2021 •
edited by lionel-
Loading

Closes #213

@jimhester
Copy link
Member

Does the fact that the error message is translated mean this experiment failed?

@hadley
Copy link
Member Author

hadley commented Nov 8, 2021

Yeah, experiments are on going 😄

@hadley hadley marked this pull request as ready for review November 8, 2021 19:14
@hadley hadley mentioned this pull request Nov 8, 2021
Merged
@lionel- lionel- mentioned this pull request Jan 9, 2024
Closed
@lionel- lionel- merged commit a57401a into main Jan 9, 2024
11 checks passed
@lionel- lionel- deleted the bindtext2 branch January 9, 2024 14:56
@lionel-
Copy link
Member

lionel- commented Jan 9, 2024

@hadley I took a look and your workaround seems to fix the cache invalidation issues in #213! It just needed to be run inside defer().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with_language() fails to reset the cache on Alpine Linux
3 participants
@hadley @jimhester @lionel-