Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shiny_file breaks with development version of shiny #80

Closed
cpsievert opened this issue Jun 14, 2022 · 0 comments · Fixed by #81
Closed

shiny_file breaks with development version of shiny #80

cpsievert opened this issue Jun 14, 2022 · 0 comments · Fixed by #81

Comments

@cpsievert
Copy link
Contributor

I noticed this our revdepchecks with our shiny 1.7.2 release candidate (which adds a new argument to shiny::fileInput()):

> ymlthis::shiny_file(label = "file", multiple = TRUE)
Error: Mapped vectors must have consistent lengths:
* `.x` has length 6
* `.y` has length 7

Looks as though all the ymlthis::shiny_*() functions are susceptible to breakage if shiny adds arguments

cpsievert added a commit to cpsievert/ymlthis that referenced this issue Jun 14, 2022
… set of arguments is different between the mock call and formal arguments
cpsievert added a commit to cpsievert/ymlthis that referenced this issue Jun 14, 2022
… set of arguments is different between the mock call and formal arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant