Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to C++14 under Boost 1.75.0 #49

Closed
eddelbuettel opened this issue Dec 13, 2020 · 0 comments
Closed

Switch to C++14 under Boost 1.75.0 #49

eddelbuettel opened this issue Dec 13, 2020 · 0 comments
Assignees

Comments

@eddelbuettel
Copy link
Contributor

As mentioned in issue 76 at the BH repo, its new version requires a switch of rlas to C++14 and will no longer compile with C++11. I have checked that this works, and can confirm that C++14 is allowed at CRAN. I have not checked if the switch to C++14 causes and issue under the current BH package (using Boost 1.72.0).

It would be great if you could consider upgrading to C++14 and upload an updated package, likely only once CRAN reopens in January, A simple patch is included below.

Please reach out if you have any questions, and a big Thank You! for maintaining rlas on CRAN.

diff -ru rlas.orig/src/Makevars rlas/src/Makevars
--- rlas.orig/src/Makevars      2019-09-06 12:09:32.000000000 +0200
+++ rlas/src/Makevars   2020-12-12 22:59:03.333898341 +0100
@@ -59,4 +59,4 @@
 TEMP1   =  $(SOURCES:.cpp=.o)
 OBJECTS =  $(TEMP1:.c=.o)
 
-CXX_STD = CXX11
+CXX_STD = CXX14
Only in rlas/src: Makevars~
diff -ru rlas.orig/src/Makevars.win rlas/src/Makevars.win
--- rlas.orig/src/Makevars.win  2019-04-26 15:15:49.000000000 +0200
+++ rlas/src/Makevars.win       2020-12-13 15:37:38.045303228 +0100
@@ -59,4 +59,4 @@
 TEMP1   =  $(SOURCES:.cpp=.o)
 OBJECTS =  $(TEMP1:.c=.o)
 
-CXX_STD = CXX11
+CXX_STD = CXX14
@Jean-Romain Jean-Romain self-assigned this Dec 13, 2020
Jean-Romain added a commit that referenced this issue Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants