add Text Area Description to header reader/writer #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean-Romain
reviewed
Aug 1, 2023
src/readheader.cpp
Outdated
| if (vlr.record_id == 3) // TextArea | ||
| { | ||
| CHAR* text_area_description = (CHAR*) vlr.data; | ||
| lvlr.push_back(nullterminate(text_area_description, vlr.record_length_after_header)); |
There was a problem hiding this comment.
The standard already imposes that the string are null terminated. No need to enforce it. The nullterminate function is only a trick to make the CRAN happy with (valid) non null terminated string (but we loose 1 character). We should not use it otherwise.
There was a problem hiding this comment.
Done, sorry for the iterative commit...
Jean-Romain
reviewed
Aug 1, 2023
src/writeLAS.cpp
Outdated
| CharacterVector desc = vlr["description"]; | ||
| std::string sdesc = as<std::string>(desc); | ||
| I32 sascii_size = sascii.size(); | ||
| if ((sizeof(CHAR)*sascii_size) > U16_MAX) |
There was a problem hiding this comment.
Be careful if you truncate the string it must be null-terminated. You must add \0 at position U16_MAX-1
There was a problem hiding this comment.
I have added a null terminator to text of any length as it is not done by LASlib.
Therefore, length_after_header == nchar(vlr$text_area_description)+1 always.
|
Thank you. Nice to see you back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current PR, I propose an implementation of the VLR Text Area Description for header reader/writer.
In writeLAS.cpp, when the data of the text area is more than 65535 characters (2^16-1), it is truncated.
By the way, I also removed an excessive indentation in readher.cpp.
I PR on master branch as I noticed that devel branch was much older.