Fix install_svn and related functions #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! THis is great! Don't worry about the appveyor failure, that seems to be a separate issue. |
jimhester
added a commit
to jimhester/devtools
that referenced
this pull request
Dec 22, 2016
This is a conversion of r-lib/remotes#33 to devtools. Essentially is removes the branch argument and assumption of SVN branch or trunk layout, as there is no true standard in SVN. Fixes r-lib#1423
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bug in install_svn() that stops it from working with R-forge. It no longer edits the URL, adding "trunk" or "branches" onto it.
Since this makes it incompatible with the original, I also simplified things so they make more sense from an SVN point of view: I dropped the "branch" argument, used "export" instead of "checkout", and chose the revision at time of export, rather than exporting the head and updating afterwards.