New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for logarithms #177
Conversation
Codecov Report
@@ Coverage Diff @@
## master #177 +/- ##
==========================================
+ Coverage 98.44% 99.48% +1.03%
==========================================
Files 18 18
Lines 964 968 +4
==========================================
+ Hits 949 963 +14
+ Misses 15 5 -10
Continue to review full report at Codecov.
|
@edzer, @t-kalinowski: I think this PR is ready. Please, take a look. Summary:
If you agree with the changes so far, we can merge this PR and close #176. Maybe the best is to avoid any automatic conversion (to dBW, etc.) at the moment: we can always revisit the discussion in #176 if the users demand that feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
By the way, I find your recent comments in #176 convincing, and I think it's probably OK to do automatic conversion. |
Nooo... Did we convince each other? :D :D :D |
Ok, I've added a couple of tests for the decibel too. May I squash and merge this, @edzer? |
Yes, very good - go ahead. Great work!! |
Initial implementation to address issues in #176.