Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #208: validate units before installation #209

Merged
merged 4 commits into from May 26, 2019
Merged

Fix #208: validate units before installation #209

merged 4 commits into from May 26, 2019

Conversation

Enchufa2
Copy link
Member

Current checks:

  • Leading and trailing numbers.
  • Arithmetic operators.
  • Intermediate white spaces.

Am I missing something?

@Enchufa2 Enchufa2 requested a review from edzer May 25, 2019 11:39
@codecov
Copy link

codecov bot commented May 25, 2019

Codecov Report

Merging #209 into master will increase coverage by 0.28%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
+ Coverage   94.23%   94.51%   +0.28%     
==========================================
  Files          18       18              
  Lines         919      930      +11     
==========================================
+ Hits          866      879      +13     
+ Misses         53       51       -2
Impacted Files Coverage Δ
R/deprecated.R 83.33% <100%> (ø) ⬆️
R/make_units.R 94.31% <100%> (-0.07%) ⬇️
R/user_conversion.R 94.11% <100%> (+12.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7da0e9f...f2b5c2f. Read the comment docs.

@edzer edzer merged commit 9cd6b65 into master May 26, 2019
@edzer
Copy link
Member

edzer commented May 26, 2019

Looks good & makes a lot of sense - thanks!

@Enchufa2 Enchufa2 deleted the fix-208 branch August 20, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants