Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load_units_xml() #254

Merged
merged 4 commits into from Nov 18, 2020
Merged

Add load_units_xml() #254

merged 4 commits into from Nov 18, 2020

Conversation

Enchufa2
Copy link
Member

@Enchufa2 Enchufa2 commented Nov 7, 2020

New function to load a user-provided XML file or to reload the default one if no path is provided. Closes #243 (not supported) and #244 (addressed here).

@Enchufa2 Enchufa2 requested a review from edzer November 7, 2020 17:00
@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #254 (5b1d02c) into master (5167a69) will decrease coverage by 0.10%.
The diff coverage is 85.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
- Coverage   94.20%   94.09%   -0.11%     
==========================================
  Files          19       20       +1     
  Lines         914      897      -17     
==========================================
- Hits          861      844      -17     
  Misses         53       53              
Impacted Files Coverage Δ
R/init.R 8.33% <50.00%> (-7.06%) ⬇️
R/database.R 81.48% <81.48%> (ø)
R/valid_udunits.R 100.00% <100.00%> (+7.93%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc1911f...5b1d02c. Read the comment docs.

@Enchufa2
Copy link
Member Author

@edzer Kind reminder.

@edzer edzer merged commit 541a96c into master Nov 18, 2020
@edzer
Copy link
Member

edzer commented Nov 18, 2020

Great work - thanks!!

@Enchufa2 Enchufa2 deleted the feature/244 branch November 18, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow local versions of database
2 participants