Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please export ud_are_convertible() #258

Closed
cregouby opened this issue Nov 18, 2020 · 1 comment · Fixed by #263
Closed

Please export ud_are_convertible() #258

cregouby opened this issue Nov 18, 2020 · 1 comment · Fixed by #263

Comments

@cregouby
Copy link
Contributor

Hello,

In a recent PR to improve prettyunits::pretty_num() with support of units, I've been using the private function units:::ud_are_convertible().
This makes my PR at risk for the future, and I would like to ask you to export that function in your package.

Of course adding a local pretty_num.units() function could be an alternative way-forward.

Please let me know.

@edzer
Copy link
Member

edzer commented Nov 18, 2020

I'm open for both options; since prettyunits provides the generic it might make sense to keep the units method there as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants