Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow longer group options #270

Merged
merged 1 commit into from Mar 10, 2021
Merged

Allow longer group options #270

merged 1 commit into from Mar 10, 2021

Conversation

bart1
Copy link
Contributor

@bart1 bart1 commented Mar 10, 2021

This addresses #269

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #270 (f84e425) into master (89a5afa) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
- Coverage   94.15%   94.14%   -0.01%     
==========================================
  Files          18       18              
  Lines         872      871       -1     
==========================================
- Hits          821      820       -1     
  Misses         51       51              
Impacted Files Coverage Δ
R/options.R 100.00% <100.00%> (ø)
src/udunits.cpp 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89a5afa...21b96e8. Read the comment docs.

@Enchufa2
Copy link
Member

LGTM, thanks!

@Enchufa2 Enchufa2 merged commit fe7d229 into r-quantities:master Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants