Label argument not working

[laldew]

Thanks for your work on this library!

I cannot figure out how to get a label to display on hover. Please see example below:

if (interactive()) {
    library(leaflet)
    library(leafgl)
    library(sf)
    
    gadm = st_as_sf(gadmCHE)
    gadm = st_cast(gadm, "POLYGON")
    cols = grey.colors(nrow(gadm))
    
    leaflet() %>%
        addProviderTiles(provider = providers$CartoDB.DarkMatter) %>%
        addGlPolygons(data = gadm, color = cols, popup = TRUE, label=gadm$NAME_1)
}

[trafficonese]

There is currently no hover event, so labels wont work.

[xiaofanliang]

Would love to be able to have the hover label!!

[trafficonese]

Apparently with commit b469ee6 labels should be working..
But it is not working for me and I dont think it should aswell, since the data only has the property id, because we remove all other columns in the R methods.

@tim-salabim Did I break something with my latest merge? It's weird, as at some point I also had labels working but now I am getting this error, which makes sense since the features only have the property id.

Cannot read properties of undefined (reading 'toString')

[tim-salabim]

@tim-salabim Did I break something with my latest merge?

Not sure. I can look into this at some stage, but probably not before next week

[trafficonese]

The labels currently only work, when popup = TRUE as then we dont remove any data columns.
We have this which also doesnt really make sense or?

else if (isTRUE(popup)) {
    data = data[, popup]
  }

I am thinking of using labels <- leaflet::evalFormula(label, data) before the popup part and pass this vector to Glify, then we can use formulas too and the interface is identical for lines/points/polygons and also to leaflet.