Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind st_astext from lwgeom #25

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Bind st_astext from lwgeom #25

merged 2 commits into from
Aug 28, 2018

Conversation

etiennebr
Copy link
Member

@etiennebr etiennebr commented Jul 19, 2018

Related: r-spatial/sf#703

This will dramatically speedup the WKT conversion. I've used the postgis function names (st_asewkb and st_astext), I don't know if there is a convention to avoir collisions and keep compatibility with ISO and Postgis?

Summary:

  • adds st_astext and st_asewkb (I adapted the documentation from sf::st_as_text)
  • enables lwgeom_to_wkt through CPL_sfc_to_wkt
  • add RStudio files

* adds `st_astext` and `st_asewkb`
* enables `lwgeom_to_wkt` through `CPL_sfc_to_wkt`
@etiennebr
Copy link
Member Author

@edzer if you agree with the PR, this would be ready to merge.

@edzer edzer merged commit b16b51d into r-spatial:master Aug 28, 2018
@edzer
Copy link
Member

edzer commented Aug 28, 2018

Looking good -- thanks!

@edzer
Copy link
Member

edzer commented Nov 21, 2018

I renamed argument precision to digits; let me know if you disagree.

@etiennebr
Copy link
Member Author

Great! I'm sorry I thought I had renamed it. But maybe it was only in sf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants