Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using wk::validate_wk_wkt() and wk::validate_wk_wkb() with unclassed input #154

Closed
paleolimbot opened this issue Dec 26, 2021 · 1 comment

Comments

@paleolimbot
Copy link
Collaborator

In the forthcoming wk release, these were slated to change to error for objects that don't inherit from wk_wkt and wk_wkb, respectively. In s2, they're used to give pretty error messages for invalid WKB in s2::s2_geog_from_text()/wkb. I reverted the change to avoid breaking anything on CRAN, but this should get fixed in the development version. The correct usage would be attributes(x) <- NULL; wk::validate_wk_wkt(new_wk_wkt(x)).

@paleolimbot
Copy link
Collaborator Author

This was fixed in #155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant