Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix sanitizer error #238

Merged
merged 1 commit into from
May 16, 2023
Merged

Attempt to fix sanitizer error #238

merged 1 commit into from
May 16, 2023

Conversation

paleolimbot
Copy link
Collaborator

Closes #236.

This doesn't seem to slow down covering calculations:

library(s2)

countries <- s2_data_countries()

bench::mark(
  s2_covering_cell_ids(countries, max_cells = 100)
)
#> # A tibble: 1 × 6
#>   expression                                            min   median `itr/sec`
#>   <bch:expr>                                       <bch:tm> <bch:tm>     <dbl>
#> 1 s2_covering_cell_ids(countries, max_cells = 100)    163ms    165ms      6.08
#> # ℹ 2 more variables: mem_alloc <bch:byt>, `gc/sec` <dbl>

In theory it allocates more memory during them, but I'm not sure that 64 * sizeof(void*) - even recursively - is causing much of a problem in its use here.

@codecov-commenter
Copy link

Codecov Report

Merging #238 (af66be2) into main (7dbf4d2) will not change coverage.
The diff coverage is n/a.

❗ Current head af66be2 differs from pull request most recent head ef8c1f8. Consider uploading reports for the commit ef8c1f8 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files          46       46           
  Lines        3524     3524           
=======================================
  Hits         3314     3314           
  Misses        210      210           

@paleolimbot paleolimbot mentioned this pull request May 12, 2023
@edzer edzer merged commit 4fe0c97 into main May 16, 2023
9 checks passed
@edzer
Copy link
Member

edzer commented May 16, 2023

Will submit to CRAN with this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new CRAN message
3 participants