Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include st_queen and st_rook as functions under st_relate #1197

Closed
angela-li opened this issue Nov 19, 2019 · 2 comments
Closed

Include st_queen and st_rook as functions under st_relate #1197

angela-li opened this issue Nov 19, 2019 · 2 comments

Comments

@angela-li
Copy link
Member

angela-li commented Nov 19, 2019

It would be useful to include st_queen and st_rook explicitly in sf, as versus just in the st_relate documentation (or in the sf Github issues) . It's a common enough operation for spatial weights that I find myself having to look up the DE-9IM pattern or referencing the documentation a lot. It's also hard to explain DE-9IM patterns to people who are just starting to use R for spatial analysis.

It'd be great if it could be included in the package as functions, possibly here?

@rsbivand
Copy link
Member

rsbivand commented Nov 20, 2019

Please explain why? I think that https://keen-swartz-3146c4.netlify.com/area-data-and-spatial-autcorrelation.html#spatial-weights-matrices is very clear, that just using sf is inefficient (same story in https://r-spatial.github.io/spdep/articles/nb_sf.html#comparison-of-sp-and-sf-approaches). I cannot see any reason to confuse users who might think that sf does statistical analysis, it does not. Packages should have clearly defined tasks. You should never have to look further than documentation that already exists, and that you contributed to (see also https://edzer.github.io/UseR2019/part2.html#graphweight-based-neighbours). Unless you need to teach from DE-9IM, you don't need that listing of relationships.

@edzer
Copy link
Member

edzer commented Nov 22, 2019

Agreeing mostly with @rsbivand , in addition I am against adding functions that are one-liners really.

@edzer edzer closed this as completed Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants