New approach to register tidyverse S3 class #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove is.na.crs from docs * Remove is.na.m_range / is.na.z_range from docs. * Redocument with roxygen2 7.3.1
…andalone("r-lib/rlang", "s3-register")`
olivroy
changed the title
|
Works now. sf suggests dplyr 1.0, which is 4 years old. I think this is fine. here is a switch that was made recently r-lib/bench@4dbd656#diff-fbc888a8d95ca11d7f17e5eaa27a08a3d3cb183803ae509deea6aa51f61183fb |
olivroy
changed the title
|
I reverted unrelated changes and just included the S3 register refactor! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use new way to register S3 methods with
usethis::use_standalone("r-lib/rlang", "s3-register"). https://r-pkgs.org/dependencies-in-practice.html#imports-and-exports-related-to-s3I also removed some S3 methods from docs, for which it is not very necessary.format(),is.na(), or print methods as they are obvious.As you see in the preview, the man page looks cleaner! (no more .sf suffix)
