Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required gdal version & fix error #686

Closed
wants to merge 1 commit into from
Closed

Update required gdal version & fix error #686

wants to merge 1 commit into from

Conversation

rundel
Copy link
Contributor

@rundel rundel commented Mar 23, 2018

The inclusion of gdal_utils.h requires gdal > 2.1, this was not reflected in the DESCRIPTION file.

Additionally, the ordering of version check and #include "gdal_utils.h" resulted in the compiler failing at the include rather than the more useful error message. I've just swapped those lines and included gdal_version.h to ensure the macro values are defined.

It seems like this check should be moved into configure.ac but I'm not that ambitious at the moment.

@edzer
Copy link
Member

edzer commented Mar 23, 2018

Thanks for notifying! An alternative solution would be to make the whole gdal_utils stuff conditional to 2.1 availability, and keep 2.0 as requirement.

@rundel
Copy link
Contributor Author

rundel commented Mar 23, 2018

That would also be a good solution, I just got bit by this when updating on some machines running Fedora 23. Having an error message only about gdal_utils.h was non-obvious about the underlying cause.

edzer added a commit that referenced this pull request Mar 23, 2018
edzer added a commit that referenced this pull request Mar 23, 2018
@edzer edzer closed this Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants