Update st_ll_sample for regular sample on LINES
#725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Same code as in {sp} for `type="regular"`
- Set `offset` as random for a random starting point.
- Drop units of `l` necessary for `type="regular"`, otherwise units problem in `grp`. It may be necessary to add `@importFrom units drop_units`
- If only a unique "size" is fixed, then sample will be regular over all. This means one point every x meter. I guess this is similar to `type = random` where not the same number of points are sampled on each line. Can maybe add some information about this in the doc.
edzer
requested changes
Apr 26, 2018
R/sample.R
Outdated
| message_longlat("st_sample") | ||
| st_crs(x) = NA_crs_ | ||
| } | ||
| l = drop_units(st_length(x)) |
There was a problem hiding this comment.
see travis output: drop_units is not found.
R/sample.R
Outdated
| lcs = c(0, cumsum(l)) | ||
| grp = split(d, cut(d, lcs, include.lowest = TRUE)) | ||
| grp = lapply(seq_along(x), function(i) grp[[i]] - lcs[i]) | ||
| st_sfc(CPL_gdal_linestring_sample(x, grp), crs = st_crs(x)) |
There was a problem hiding this comment.
For PR's in general, try to keep the source formatting, so that we can see what you actually changed.
|
It was not really easy to find where you call the
|
edzer
approved these changes
May 29, 2018
edzer
added a commit
that referenced
this pull request
May 29, 2018
|
Thanks for the PR! Things should now have been merged; please test. |
|
Tested. It works ! |
|
That one is more tricky! Looking forward to a PR, |
|
Now available in branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update for regular sample is only for lines.
type="regular"offsetas random for a random starting point.lnecessary fortype="regular", otherwise units problem ingrp.@importFrom units drop_unitstype = randomwhere not the same number of points are sampled on each line.