Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make st_get_time() similar to st_geometry() #4

Closed
henningte opened this issue Nov 27, 2021 · 2 comments
Closed

Make st_get_time() similar to st_geometry() #4

henningte opened this issue Nov 27, 2021 · 2 comments

Comments

@henningte
Copy link
Collaborator

st_get_time() currently only extracts the time column. It may be useful to transform this function into a method to get or set the active time column in an sftime object similar to how st_geometry() can be used to get or set the active geometry column in an sf object.

I'm not sure how to name such a generic to avoid conflicts with the other packages. Perhaps st_tc_column()?

Similar to sf, a st_get_time() function could remain in sftime.

@edzer
Copy link
Member

edzer commented Nov 27, 2021

st_time()? (with an st_time<-() method so that st_time(obj)<-"time_col" sets it, and an st_set_time() alias for use in pipes)

henningte added a commit to henningte/sftime that referenced this issue Dec 19, 2021
@henningte
Copy link
Collaborator Author

This should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants