Adjacency rcpp code #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged it, really neat stuff Jakub :-) If you see something I miss to replace in the next days or have an idea to replace something we did - just drop me a message ✌️ |
|
Sure thing @marcosci. I am really happy that is useful. |
|
BTW @marcosci and @mhesselbarth - I am quite bad in c++, but I enjoy it a little bit. Let me know if there are any pieces of code that are still slow and their rcpp counterparts are needed. |
|
It would be really helpful if one can specify the neighborhood of your adjacency function using e.g. a matrix and not being "limited" to the queen's or rook's case (comparable to the raster::adjacency directions option). |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is also a few helper functions that potentially could be helpful...
#19