Add support for sparse updates #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalathreya
force-pushed
the
sparse
branch
from
1fd844f
to
4c59ba4
Compare
Add function to "checkout" latest committed model state
vishalathreya
force-pushed
the
sparse
branch
from
4c59ba4
to
1cbd892
Compare
vishalathreya
commented
Nov 16, 2022
| logging.debug(f"Writing {param_name} updates to {param_file}") | ||
| # file_io.write_tracked_file(param_file, param) | ||
| os.makedirs(updates_dir, exist_ok=True) | ||
| sparse.save_npz(param_file, param) |
There was a problem hiding this comment.
Encountered an issue when storing sparse CSR matrices using TensorStore. Saved it as npz files to git as a temporary solution.
vishalathreya
commented
Nov 16, 2022
| return final_val | ||
|
|
||
|
|
||
| def get_prev_param_dict(theta_model_dir): |
There was a problem hiding this comment.
replace the for loop in the smudge filter with this function to "checkout" latest committed state of model
|
Fixed in #128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to "checkout" latest committed model state
When
git theta addis run with the--update_type sparseargument, sparse updates are computed by comparing current model checkpoint with the latest committed checkpoint under.git_thetaand are stored underupdatessubfolder under each parameter group. Latest committed checkpoint can be retrieved (checkout) by loading the dense values underparamsfolder and sequentially applying all files underupdates