Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a draft of two things, first of using plugins for update types, the second is for using git to store and fetch updates that are based on deltas from previous values.
Points of Interest:
metadata
file for the parameter within the parameter directory. This was critical for the model checkpoint clean filter running in contexts likegit status
git checkout ${COMMIT}
happens the version of the cleaned model checkpoint from that commit is passed via CLI, but the parameter values start with the ones on disk. For the disk only solution this is ok (as long as the parameters were checked out before the checked-in model checkpoint is smudged, which currently happens because.git_theta
sorts first). For this solution you end up with a wrong checkpoint where the parameters are from the commit you are leaving instead of the commit you are entering. This can be fixed by runninggit reset --hard
after the checkout happens. But any thoughts on how to fix this would be great.git-theta-filter
doesn't get shown on the screen. We should revert this or make logging more robust before merging.Depends on #74, once that is merged the changes here will be easier to see.