cready to submit CRAN 3.3-4

r-tmap · Sep 12, 2023 · f6681e3 · f6681e3
1 parent 3ec8ecc
commit f6681e3
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -16,7 +16,7 @@ Authors@R: c(
 	)
 Description: Thematic maps are geographical maps in which spatial data distributions are visualized. This package offers a flexible, layer-based, and easy to use approach to create thematic maps, such as choropleths and bubble maps.
 Version: 3.3-4
-Date: 2023-09-08
+Date: 2023-09-12
 Encoding: UTF-8
 Depends:
     R (>= 3.5.0),

diff --git a/R/tmap_save.R b/R/tmap_save.R
@@ -200,7 +200,7 @@ tmap_save <- function(tm=NULL, filename=NA, device=NULL, width=NA, height=NA, un
 
 	if (!is.arrange && !missing(insets_tm) && !missing(insets_vp)) {
 	  args_inset <- if (!is.na(scale)) list(scale = scale) else list()
-	  if (class(insets_tm)=="list" && class(insets_vp)=="list") {
+	  if (inherits(insets_tm, "list") && inherits(insets_vp, "list")) {
 	    if (length(insets_tm) != length(insets_vp)) stop("Number of insets unequal to number of viewports")
 	    mapply(function(tm_i, vp_i) {
 	      print(tm_i + do.call("tm_layout", args_inset), vp=vp_i)

diff --git a/README.md b/README.md
@@ -152,7 +152,7 @@ Please tag your questions with *tmap*.
   [17]: http://www.computerworld.com/article/2921176/business-intelligence/great-r-packages-for-data-import-wrangling-visualization.html
   [18]:	http://www.computerworld.com/article/3175623/data-analytics/mapping-in-r-just-got-a-whole-lot-easier.html
   [19]: https://sesync-ci.github.io/maps-in-R-lesson/
-  [20]: http://geocompr.robinlovelace.net/adv-map.html
+  [20]: https://r.geocompx.org/adv-map
   [21]: https://mtennekes.github.io/downloads/presentations/tmap_user2017.pdf
   [22]: https://gotellilab.github.io/Bio381/StudentPresentations/SpatialDataTutorial.html
   [23]: https://mtennekes.github.io/downloads/presentations/tmap_opengeo_muenster.pdf

diff --git a/cran-comments.md b/cran-comments.md
@@ -1,6 +1,5 @@
 ## Test environments
-* ubuntu 14.04 (on travis-ci), R 3.5.1 and R devel
-* ubuntu 20.04.2, R 4.1.2
+* MacOS 13.4.1, R 4.3.1
 * win-builder (devel and release)
 
 ## Submission note

diff --git a/vignettes/tmap-getstarted.Rmd b/vignettes/tmap-getstarted.Rmd
@@ -23,7 +23,7 @@ A more detailed description of tmap can be found in an [article](https://www.jst
 However, that article describes tmap version 1.11-2, which is out-of-date.
 Some major changes have been made since then, which are described in [`vignette("tmap-changes")`](../doc/tmap-changes.html).
 
-For more context on R's geographic capabilities we recommend the online version of the book [Geocomputation with R](https://geocompr.robinlovelace.net/). The [Making maps with R](https://geocompr.robinlovelace.net/adv-map.html) chapter of the book provides many more context and abundant code examples of map making with `tmap` and other packages. Other good resources are the vignettes of the [`sf` package](https://CRAN.R-project.org/package=sf/vignettes/sf1.html).
+For more context on R's geographic capabilities we recommend the online version of the book [Geocomputation with R](https://r.geocompx.org/). The [Making maps with R](https://r.geocompx.org/adv-map) chapter of the book provides many more context and abundant code examples of map making with `tmap` and other packages. Other good resources are the vignettes of the [`sf` package](https://CRAN.R-project.org/package=sf/vignettes/sf1.html).
 
 
 ### Hello World!