Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle pfaelde for map matching of routes #156

Open
mpadge opened this issue Sep 2, 2020 · 4 comments
Open

Bundle pfaelde for map matching of routes #156

mpadge opened this issue Sep 2, 2020 · 4 comments

Comments

@mpadge
Copy link
Contributor

mpadge commented Sep 2, 2020

---Just an idea---
The excellent pfaedle library uses OSM input to do precise map-matching between GTFS stops. It's GPL-3 licenced, so could be bundled here without infringement.

what it would do

shape tables don't exist for all feeds, and even where they do, are often just made from straight lines between stops. pfaedle library fills in all the gaps, and gives you very precise shape tables.

why here?

This functionality would be really cool, and tidytransit seems like a better home than gtfsrouter.

other thoughts

I'd be happy to help if you were interested, although most likely to rapidly progress if somebody else could chip in with the C++ skills, because I'm not sure I'd have so much time to offer. Let me know what you think, and we could maybe at least s-l-o-w-l-y get going ...

ping @AlexandraKapp: would you be interested in this kind of functionality?

@polettif
Copy link
Contributor

polettif commented Sep 3, 2020

That's a great idea. I've been using pfaedle in other workflows and it's really quite nifty. However, I don't have any C++ or Rcpp skills, so any help would be greatly appreciated.

Maybe a function interface to a pfaedle's command line calls (or something like that) whitout bundling it with tidytransit could be a first step.

@mpadge
Copy link
Contributor Author

mpadge commented Sep 3, 2020

Maybe a function interface to a pfaedle's command line calls (or something like that) whitout bundling it with tidytransit could be a first step.

That would be quite difficult to get that on CRAN, because you'd need to automate the system install for all checks anyway, which wouldn't be much less difficult that just bundling. I'll definitely try to find time to do it soon-ish - feel free to ping me anytime if you think i might be taking too long.

@polettif
Copy link
Contributor

polettif commented Sep 3, 2020

That would be quite difficult to get that on CRAN, because you'd need to automate the system install for all checks anyway, which wouldn't be much less difficult that just bundling.

Ah, just don't include it in the tests ;) Nah that's a good point. Plus, pfaedle's not in rapid development anymore anyways so bundling's fine.

I'll definitely try to find time to do it soon-ish - feel free to ping me anytime if you think i might be taking too long.

Thanks! I'll keep this earmarked.

@AlexandraKapp
Copy link
Contributor

ping @AlexandraKapp: would you be interested in this kind of functionality?

Sounds like a great idea! Generally this could be interesting for us, but probably not the most importpant currently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants