Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for pop new parachain #13

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

brunopgalvao
Copy link
Collaborator

@brunopgalvao brunopgalvao commented Mar 1, 2024

Please review the code and see if you are happy with the tests.

cargo test

@brunopgalvao brunopgalvao requested review from weezy20 and AlexD10S and removed request for weezy20 March 1, 2024 13:14
@weezy20
Copy link
Collaborator

weezy20 commented Mar 1, 2024

LG. Can the same be done for pop new pallet (#6)? Just testing for existence like the other tests would suffice.

@AlexD10S
Copy link
Collaborator

AlexD10S commented Mar 1, 2024

Looks good!

For the CLI I found a tutorial showing how to test the CLI inputs: https://rust-cli.github.io/book/tutorial/testing.html#testing-cli-applications-by-running-them

@brunopgalvao brunopgalvao merged commit 893b08f into main Mar 1, 2024
@AlexD10S AlexD10S mentioned this pull request Mar 2, 2024
2 tasks
@Daanvdplas Daanvdplas deleted the add-unit-test-new-parachain branch March 17, 2024 15:55
This was referenced Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants