-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pop build parachain #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One thing that I found is that the executable is still called parachain-template-node
Doesn't matter for the demo but should be called the same as the project name tmo
pub(crate) fn execute(&self) -> anyhow::Result<()> { | ||
clear_screen()?; | ||
intro(format!( | ||
"{}: Building a parachain", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we change this from "Building a parachain" to "Building <parachain_project_name>"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are in your parachain directory and you run pop build parachain
it builds the parachain without need of indicating the name or the path of the parachain.
So I think to get the name and print this message we will have to parse Cargo.toml
. Do we want this logic now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is just a nice UX thing so we can leave it for later (if others think this is a nice feature too)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are in your parachain directory and you run
pop build parachain
it builds the parachain without need of indicating the name or the path of the parachain.So I think to get the name and print this message we will have to parse
Cargo.toml
. Do we want this logic now?
Is this the same for pop build contract
? It would be nice.
Basic functionality for building a parachain.
Merging it before sub0 to have at least this functionality there as requested by Daan. But will be nice to have these other functionality too #28 and #29 for
pop build parachain
To test, after create the parachain, execute:
Closes #2