Do not use wrap-form-element for uncontrolled inputs

[tonsky]

When using uncontrolled inputs (defaultValue instead of value, defaultChecked instead of checked), wrap-form-element will eventually convert it to controlled one by setting value on it. React will issue a warning about switching between controlled and uncontrolled flavours which is considered not really supported.

This patch checks if generated input is controlled or not, and switches to wrapped form only for controlled elements.

It also

• saves one closure allocation ((partial js/React.createElement (name type)))
• fixes displayName
• replaces createFactory and React.DOM (both considered legacy) with React.createElement

[r0man]

@tonsky Thanks for the patch. What about the "option" tag, does it not need to be wrapped anymore?

[tonsky]

I don’t think so, no. In React, you set selected value on select, not by specifying selected=true on option as in HTML. React option doesn’t have controlled/uncontrolled variety. Select does. That’s why I’ve added select to wrapped elements in my patch (it was filtered out before by wrapped-type?)

[r0man]

Ok, thanks for the explanation.

[r0man]

@tonsky Just pushed 0.7.3-SNAPSHOT to Clojars.

[tonsky]

awesome!

On Tue, Jul 5, 2016 at 12:32 AM r0man notifications@github.com wrote:

@tonsky https://github.com/tonsky Just pushed 0.7.3-SNAPSHOT to Clojars.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#123 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AARabPBygWKqvLuxCzN2hTi46Gcehq0eks5qSVHEgaJpZM4JEfxk
.