Speed boost by removing clj->js and using transducers where applicable
#133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry - I didn't note that the Phantom tests are failing. Fix comes ASAP. |
|
@the-kenny I am AFK at the moment. I'll take a look at this over the weekend. Thanks! |
|
@the-kenny Could you add your before/after comparisons of your rendering process? |
|
@the-kenny I tested this on one of my projects. Looks good. Could you please rebase on master. I changed the tests to use Tubax instead of Hickory. Thanks! |
|
@r0man Rebase will come in a minute - not sure if I can get to before/after comparisons today. I'll add them asap. |
Most notably: - Replace most usages of nested map/filter/zip-map with transducers - Get rid of `clj->js` in `sablono.interpreter/attributes`
the-kenny
force-pushed
the
speed-boost
branch
from
d1239df
to
3efe976
Compare
|
I rebased and commited this to master. Thanks! |
|
Awesome! :) |
dwwoelfel
reviewed
Jan 9, 2017
|
|
||
| (defn compile-attrs | ||
| "Compile a HTML attribute map." | ||
| [attrs] | ||
| (->> (seq attrs) | ||
| (map #(apply compile-attr %1)) | ||
| (apply merge) | ||
| (reduce (fn [attrs [name value]]some |
There was a problem hiding this comment.
What is the some at the end of the line doing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request implements various small changes which will in sum improve the performance of
interpretmassively.In our application Pepa we saw slow rendering times dominated by sablono's usage of
clj->jsinsablono.interpreter/attributes. While learning about the internals of sablono I noticed various sub-optimal usages of sequence APIs.While the major gain comes from the removal of
clj->js, the other parts should add up to something to: The transducers avoid many small allocations for LazySeqs, especially noticeable in chained sequence operations.All tests pass, and our Pepa works fine with these changes. However, I can't rule out that the removal of
clj->jswill cause semantic changes. However, these should only be noticeable in exotic usages of attribute-maps, so I doubt the majority of people should see any change at all (except for better performance of course).You can test out my changes by using
[de.tarn-vedra/sablono "0.7.6-SNAPSHOT"]If you're interested I can also post some before/after comparisons of our rendering process, but these will just be micro-benchmarks where I take a screenshot of Chrome's flame-graph before and after my changes :-)