Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed react-fn to a multimethod #173

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zcaudate
Copy link

@zcaudate zcaudate commented Jun 9, 2017

in reference to #46 suggestion that react-fn should be a multimethod.

@r0man
Copy link
Owner

r0man commented Jun 10, 2017

@zcaudate Thanks for the PR! However, I'm not sure to open up this extension point in the public API (yet). I would like to wait until React 16 is released, and look into rendering JS literals before going down that route.
Also, what's the exact use case here? Usually I put smaller components into their own functions or a defelem.

@zcaudate
Copy link
Author

@r0man: no worries. I was looking around at the compiler and was wondering how to do custom elements. I'm influenced by angularjs, where you can define your own tags and directives. I know that you can do defelem, but it would be really cool if they can be defined as a html tag.

[:custom-elem {} "hello"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants