React 16

[r0man]

No description provided.

[DjebbZ]

Happy to see you started working on this !

I run the tests locally with lein ci, all passed (even in Nashorn and Phantom).

What can I do to help ? What remains to be done ?

[r0man]

@DjebbZ This depends on an unreleased version of om.next (which is used for server rendering) and in the tests. I also disabled some rum tests, since there's also no version available for React 16 I think. Ideally, I would like to enable all those tests again before cutting a release. So basically I'm waiting for releases of om.next and rum.

[DjebbZ]

I noticed the unreleased om.next, had to clone and build it locally.

I gave notice of your work in rum's repo, I think I'll try something tomorrow.

I don't see any change in your code regarding a syntax to handle React's fragments. See the discussion on reagent repo to find a common syntax for them.
Do you have a specific plan ?

[DjebbZ]

@tonsky has just released a new version of rum that supports React 16 tonsky/rum#151 (commits) v0.11.0
The only thing (I think) remaining for rum now is a Sablono version that supports React 16 fragment. At least you have a version of Rum to test.

[r0man]

@DjebbZ I updated rum, enabled its tests again and merged your fragement branch. Everything looks good. I pushed 0.8.3-SNAPSHOT to Clojars for testing. I asked David for a release of om.next with the React 16 dependencies which will happen soon. Then all tests are passing again and I will cut a release. Thanks for the fragment support and pushing this through! :)

[DjebbZ]

👍