Frameless windows (macOS implementation) #177

Fizzadar · 2018-02-14T13:29:23Z

Implements frameless windows (Cocoa only currently!).

Partly implements: #169

… view.

r0x0r · 2018-02-19T13:43:45Z

webview/__init__.py

@@ -189,6 +189,7 @@ def create_window(title, url=None, js_api=None, width=800, height=600,
    :param strings: a dictionary with localized strings
    :param confirm_quit: Display a quit confirmation dialog. Default is False
    :param background_color: Background color as a hex string that is displayed before the content of webview is loaded. Default is white.
+    :param frameless: Whether the window should havea frame.


r0x0r · 2018-02-19T13:45:38Z

webview/cocoa.py

+        screenFrame = AppKit.NSScreen.mainScreen().frame()
+        if screenFrame is None:
+            sys.stderr.write('failed to obtain screen\n')
+            raise RuntimeError


It would be better to raise a RuntimeError('Failed to obtain screen'). Same with the rest of RuntimeErrors

r0x0r · 2018-02-19T13:46:56Z

webview/cocoa.py

@@ -224,7 +271,7 @@ def performKeyEquivalent_(self, theEvent):

                    return handled

-    def __init__(self, title, url, width, height, resizable, fullscreen, min_size, background_color, debug, js_api, webview_ready):
+    def __init__(self, title, url, width, height, resizable, fullscreen, min_size, background_color, debug, js_api, webview_ready, frameless):


Please place frameless before webview_ready

r0x0r · 2018-02-19T13:47:10Z

webview/cocoa.py

@@ -244,15 +291,25 @@ def __init__(self, title, url, width, height, resizable, fullscreen, min_size, b
        if resizable:
            window_mask = window_mask | AppKit.NSResizableWindowMask

+        if frameless is True:


if frameless

r0x0r · 2018-02-19T13:47:23Z

webview/cocoa.py


-        self.webkit = BrowserView.WebKitHost.alloc().initWithFrame_(rect)
+        if frameless is True:


if frameless

Fizzadar · 2018-02-23T09:13:41Z

@r0x0r I've pushed the changes. I see the multi window branch is now merged (woo!) and will handle those conflicts too when I get a chance!

shivaprsd · 2018-02-23T17:07:33Z

webview/cocoa.py

@@ -244,15 +290,25 @@ def __init__(self, title, url, width, height, resizable, fullscreen, min_size, b
        if resizable:
            window_mask = window_mask | AppKit.NSResizableWindowMask

+        if frameless:
+            window_mask = window_mask | AppKit.NSFullSizeContentViewWindowMask | AppKit.NSTexturedBackgroundWindowMask


NSFullSizeContentViewWindowMask is now deprecated. Doesn't work in High Sierra. If
we are to use this, we would need an OS API version check. Also a way to do it in 10.13+

Edit: NSWindowStyleMaskFullSizeContentView works in High Sierra.

shivaprsd · 2018-02-23T17:14:17Z

webview/cocoa.py

+                drag_bar = DragBar.alloc().initWithFrame_(rect)
+                drag_bar.setAutoresizingMask_(AppKit.NSViewWidthSizable)
+                BrowserView.instance.window.contentView().addSubview_(drag_bar)
+


Is there a reason this code (line 204 to 215) is put here? Do we need to update the drag
bar every time the page loads? If not, the best place for it would be in the __init__()
function itself.

I managed to move it to init in 841ca88 (new to pyobjc!).

…ndows # Conflicts: # webview/cocoa.py

I have also made some small changes and bug fixes: * Default title bar height is 22; changed to it from 24. * We cannot not set content view of window in __init__, should be done in the load-finish delegate. Originally this was to support background color, but now a couple of other things depend on it as well.

Fix compatibility issues and refactor

[Qt] Correct frameless parameter position

shivaprsd · 2018-03-28T11:01:32Z

@Fizzadar @r0x0r As this PR implements the feature only in macOS, I don't
think it should go straight into master, especially since we're preparing for a
new release. I'm creating a new feature branch frameless and changing the
base of this PR to it. If this is okay, this can be merged at once.

Fizzadar · 2018-03-28T13:44:55Z

@shivaprsdv sounds good to me; definitely better than merging into master when only macOS is supported :)

r0x0r · 2018-03-30T19:33:14Z

@shivaprsdv ok to merge to a new branch

shivaprsd · 2018-03-31T10:58:49Z

@Fizzadar I considered it appropriate to do a Squash before Merge. Thanks for
the contribution! 🤗

* [All] Add skeleton for `frameless` parameter * [Cocoa] Add `frameless` kwarg to remove the window frame. - Implement a DragBar class to enable dragging the webview - Make the drag bar stick to the top and autoresize to the width of the view.

* Merge PR #177: [Cocoa] Implement frameless windows * [All] Add skeleton for `frameless` parameter * [Cocoa] Add `frameless` kwarg to remove the window frame. - Implement a DragBar class to enable dragging the webview - Make the drag bar stick to the top and autoresize to the width of the view. * [WinForms] Implement frameless window + easy drag * Merge PR #177: [Cocoa] Implement frameless windows * [All] Add skeleton for `frameless` parameter * [Cocoa] Add `frameless` kwarg to remove the window frame. - Implement a DragBar class to enable dragging the webview - Make the drag bar stick to the top and autoresize to the width of the view. * [WinForms] Implement frameless window + easy drag * [GTK] partial implementation of frameless window * [QT] Partial implementation of frameless window * [QT] implement easy drag * [Cocoa] Hide standard buttons and make the entire window draggable * [GTK] implement easy move * Add frameless tests * Remove unused parameter * [Cocoa] Implement free drag * Revert WebBrowserInterops * Code cleanup * Update interop DLLs * Fix interop dll * Update docs; Fix tests * Add example * Update examples

@HeavenVolkoff

* Update change_url.md * Update api.md * Update installation.md * Add Google Analytics * Fix installation * 2.4 info * [Docs] add information about window.pywebview availability * Update debuggig info about QTWebEngine * [Docs] Add information about app architecture * Update cef.md * [CEF] Fix JS logic not persisting after navigating to another page * #169 Frameless window (#313) * Merge PR #177: [Cocoa] Implement frameless windows * [All] Add skeleton for `frameless` parameter * [Cocoa] Add `frameless` kwarg to remove the window frame. - Implement a DragBar class to enable dragging the webview - Make the drag bar stick to the top and autoresize to the width of the view. * [WinForms] Implement frameless window + easy drag * Merge PR #177: [Cocoa] Implement frameless windows * [All] Add skeleton for `frameless` parameter * [Cocoa] Add `frameless` kwarg to remove the window frame. - Implement a DragBar class to enable dragging the webview - Make the drag bar stick to the top and autoresize to the width of the view. * [WinForms] Implement frameless window + easy drag * [GTK] partial implementation of frameless window * [QT] Partial implementation of frameless window * [QT] implement easy drag * [Cocoa] Hide standard buttons and make the entire window draggable * [GTK] implement easy move * Add frameless tests * Remove unused parameter * [Cocoa] Implement free drag * Revert WebBrowserInterops * Code cleanup * Update interop DLLs * Fix interop dll * Update docs; Fix tests * Add example * Update examples * [CEF]: Implement support for pyinstaller one-file mode * [CEF] Fix typo * [All] Change api_call timeout to 15 seconds * Update setup.py * [QT] Simplify QT installation * New API Cocoa implementation Revamped tests and examples * Fix web engine force setting * Rename destroy_window to destroy * Update documentation * Add documentation for 2.4 * Refactor project structure * [GTK] New API support * Rename confirm_quit to confirm_close Split lifecycle events to shown and loaded * [GTK] Implement new API Fix tests * [QT] New API implementation * Remove multiprocessing * [Windows/CEF] New API implementation * Implement CSRF token [All] Implement get_element * Update Flask app example * Rename get_element to get_elements. Bug fixes. * [GTK] Implement propert JS-Python bridge for WebKit2 >2.2 * Update documentation * [Windows/CEF] New API implementation * Add token test * [Winforms] Fix js api initialization * [Cocoa] Fix events * Debug: print webkit version * [GTK] Check for old webkit * [GTK] Fix event issues * Catch notimlementederror in tests * Update travis conf with qt from pip * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * [Windows] Preliminary implementation of EdgeHTML based on PR from @HeavenVolkoff * [docs] Add information about EdgeHTML * EdgeHTML WIP * Remove windows.web import * EdgeHTML improvements. Fix MSHTML evaluate_js * [Docs] Add information about renderer limitations * [EdgeHTML] Fix bugs and tests * Remove window from windows list after it is destroyed * Fix window object deletion after window is closed via GUI * [Docs] Add information about renderer codes * Refactor and fix JS API Remove multiprocessing example [MSHTML] Add console.log debug support * [Travis] Change conf * [WinForms] Fix fullscreen * Fix dll installation * [Windows] Fix DLL bundling * Update changelog * [CEF]: Fix JS API * Update changelog * Built-in HTTP server implementation * Add http server test * Add http server testcd * Add http server testcd * [EdgeHTML] allow localhost urls * Add video example * Bug fixing * [Cocoa] Remove media prefs * Update .travis.yml * Update .travis.yml * Update .travis.yml * [Travis] Disable QT 5.12 builds * Update html_load.md

Fizzadar added 3 commits January 29, 2018 22:08

[Cocoa] Add window_frame kwarg to remove the window frame.

c9e838f

Make the drag bar stick to the top and autoresize to the width of the…

bf14753

… view.

Rename window_frame kwarg to frameless.

d5a05eb

r0x0r requested changes Feb 19, 2018

View reviewed changes

Fizzadar added 4 commits February 23, 2018 09:09

Correct typo.

1f3686f

Raise with message, rather than writing/raising.

da9cb1a

Remove pointless is True when checking if frameless.

30f40e5

Switch webview_ready to be the final argument.

a793339

shivaprsd requested changes Feb 23, 2018

View reviewed changes

Fizzadar and others added 5 commits March 7, 2018 21:19

Merge branch 'master' of github.com:r0x0r/pywebview into frameless-wi…

76a53ee

…ndows # Conflicts: # webview/cocoa.py

Create the frameless drag bar on init.

841ca88

Make RuntimeErrors consistent.

83cd92b

[All] Add skeleton for frameless parameter

e76b3f9

shivaprsd mentioned this pull request Mar 24, 2018

Fix compatibility issues and refactor Fizzadar/pywebview#1

Merged

Merge pull request #1 from shivaprsdv/frameless-windows

d4dfb98

Fix compatibility issues and refactor

shivaprsd approved these changes Mar 27, 2018

View reviewed changes

[Qt] Correct frameless parameter position

c109c8a

shivaprsd changed the title ~~Frameless windows~~ Frameless windows (macOS implementation) Mar 27, 2018

Merge pull request #2 from shivaprsdv/frameless-windows

2037a3d

[Qt] Correct frameless parameter position

shivaprsd mentioned this pull request Mar 28, 2018

pywebview 2 #197

Closed

3 tasks

shivaprsd changed the base branch from master to frameless March 28, 2018 11:02

r0x0r approved these changes Mar 30, 2018

View reviewed changes

shivaprsd merged commit 9801550 into r0x0r:frameless Mar 31, 2018

Fizzadar deleted the frameless-windows branch September 5, 2018 20:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Frameless windows (macOS implementation) #177

Frameless windows (macOS implementation) #177

Fizzadar commented Feb 14, 2018 •

edited by shivaprsd

r0x0r Feb 19, 2018

r0x0r Feb 19, 2018

r0x0r Feb 19, 2018

r0x0r Feb 19, 2018

r0x0r Feb 19, 2018

Fizzadar commented Feb 23, 2018

shivaprsd Feb 23, 2018 •

edited

shivaprsd Feb 23, 2018 •

edited

Fizzadar Mar 7, 2018

shivaprsd commented Mar 28, 2018 •

edited

Fizzadar commented Mar 28, 2018

r0x0r commented Mar 30, 2018

shivaprsd commented Mar 31, 2018


		self.webkit = BrowserView.WebKitHost.alloc().initWithFrame_(rect)
		if frameless is True:

Frameless windows (macOS implementation) #177

Frameless windows (macOS implementation) #177

Conversation

Fizzadar commented Feb 14, 2018 • edited by shivaprsd

r0x0r Feb 19, 2018

Choose a reason for hiding this comment

r0x0r Feb 19, 2018

Choose a reason for hiding this comment

r0x0r Feb 19, 2018

Choose a reason for hiding this comment

r0x0r Feb 19, 2018

Choose a reason for hiding this comment

r0x0r Feb 19, 2018

Choose a reason for hiding this comment

Fizzadar commented Feb 23, 2018

shivaprsd Feb 23, 2018 • edited

Choose a reason for hiding this comment

shivaprsd Feb 23, 2018 • edited

Choose a reason for hiding this comment

Fizzadar Mar 7, 2018

Choose a reason for hiding this comment

shivaprsd commented Mar 28, 2018 • edited

Fizzadar commented Mar 28, 2018

r0x0r commented Mar 30, 2018

shivaprsd commented Mar 31, 2018

Fizzadar commented Feb 14, 2018 •

edited by shivaprsd

shivaprsd Feb 23, 2018 •

edited

shivaprsd Feb 23, 2018 •

edited

shivaprsd commented Mar 28, 2018 •

edited