Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for pip versions pre-21.3 #74

Merged
merged 1 commit into from Oct 28, 2021

Conversation

MrMino
Copy link
Collaborator

@MrMino MrMino commented Oct 27, 2021

Fixes #73

Tested this on (I've ran pip-check-reqs and pip-missing-reqs watching if there are any ImportErrors) all versions of pip above 10.0.

All work except pip==20.0 which had its own problems and IIRC was yanked from PyPI.

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #74 (f649aea) into master (f0716ac) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          587       590    +3     
=========================================
+ Hits           587       590    +3     
Impacted Files Coverage Δ
pip_check_reqs/__init__.py 100.00% <100.00%> (ø)
pip_check_reqs/common.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0716ac...f649aea. Read the comment docs.

@adamtheturtle adamtheturtle merged commit 482dfe8 into r1chardj0n3s:master Oct 28, 2021
@adamtheturtle
Copy link
Collaborator

Thank you @MrMino - if you're interested please email me / Twitter DM me about being added to this project as a maintainer.

@MrMino
Copy link
Collaborator Author

MrMino commented Oct 30, 2021

@adamtheturtle sure, I'd love that, I'll do so as soon as I'm next to my PC :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'pip._internal.metadata' for version 2.3.1
3 participants