Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: Incorrect dates for some years #5

Closed
r1zyn opened this issue Jul 24, 2022 · 2 comments
Closed

Issue: Incorrect dates for some years #5

r1zyn opened this issue Jul 24, 2022 · 2 comments
Assignees
Labels
bug Something isn't working urgent Requires urgent attention

Comments

@r1zyn
Copy link
Owner

r1zyn commented Jul 24, 2022

The program seems to be producing incorrect dates for the years 2033, 2036, 2041 and 2044.
Some of the incorrect dates may be due to lunar months, but otherwise the actual date is either the previous or next Friday.
Need to resolve both.

2033
Tangaroa Period: 20 – 23 June
Pointer Date: 20 June
Program Date: 17 June
Holiday Date: 24 June

2036
Tangaroa Period: 17 - 20 July
Pointer Date: 18 June
Program Date: 20 June
Holiday Date: 18 July

2041
Tangaroa Period: 21 - 24 July
Pointer Date: 22 June
Program Date: 21 June
Holiday Date: 19 July

2044
Tangaroa Period: 19 - 22 June
Pointer Date: 19 June
Program Date: 17 June
Holiday Date: 24 June

@r1zyn r1zyn added the bug Something isn't working label Jul 24, 2022
@r1zyn r1zyn self-assigned this Jul 24, 2022
r1zyn added a commit that referenced this issue Jul 25, 2022
@r1zyn
Copy link
Owner Author

r1zyn commented Jul 25, 2022

The date for 2044 has been resolved in 80f3eb3, Matariki couldn't occur before the 19th of June according to the 19th June rule

@r1zyn
Copy link
Owner Author

r1zyn commented Jul 25, 2022

The date for 2033 has been resolved in 23d6590

@r1zyn r1zyn added the urgent Requires urgent attention label Jul 25, 2022
@r1zyn r1zyn closed this as completed in 3ee165a Jul 26, 2022
Repository owner locked as resolved and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working urgent Requires urgent attention
Projects
None yet
Development

No branches or pull requests

1 participant