FIX: announce correct acm capabilities in usb descriptors

r2axz · Dec 4, 2020 · 1b99f5d · 1b99f5d
1 parent baddd3a
commit 1b99f5d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/usb_cdc.h b/usb_cdc.h
@@ -37,6 +37,13 @@ typedef enum {
     usb_descriptor_subtype_cdc_country         = 0x07,
 } __attribute__ ((packed)) usb_descriptor_subtype_cdc_t;
 
+#define USB_CDC_ACM_CAPABILITY_COMM_FEATURE         0x01
+#define USB_CDC_ACM_CAPABILITY_LINE_CODING          0x02
+#define USB_CDC_ACM_CAPABILITY_SEND_BREAK           0x04
+#define USB_CDC_ACM_CAPABILITY_NETWORK_CONNECTION   0x08
+
+#define USB_CDC_ACM_CAPABILITIES (USB_CDC_ACM_CAPABILITY_LINE_CODING)
+
 /* USB CDC Header Functional Descriptor */
 
 typedef struct  {

diff --git a/usb_descriptors.c b/usb_descriptors.c
@@ -145,7 +145,7 @@ const usb_device_configuration_descriptor_t usb_configuration_descriptor = {
         .bFunctionLength        = sizeof(usb_configuration_descriptor.cdc_acm_0),
         .bDescriptorType        = usb_descriptor_type_cs_interface,
         .bDescriptorSubType     = usb_descriptor_subtype_cdc_acm,
-        .bmCapabilities         = 0,
+        .bmCapabilities         = USB_CDC_ACM_CAPABILITIES,
     },
     .cdc_union_0 = {
         .bFunctionLength        = sizeof(usb_configuration_descriptor.cdc_union_0),
@@ -227,7 +227,7 @@ const usb_device_configuration_descriptor_t usb_configuration_descriptor = {
         .bFunctionLength        = sizeof(usb_configuration_descriptor.cdc_acm_1),
         .bDescriptorType        = usb_descriptor_type_cs_interface,
         .bDescriptorSubType     = usb_descriptor_subtype_cdc_acm,
-        .bmCapabilities         = 0,
+        .bmCapabilities         = USB_CDC_ACM_CAPABILITIES,
     },
     .cdc_union_1 = {
         .bFunctionLength        = sizeof(usb_configuration_descriptor.cdc_union_1),
@@ -309,7 +309,7 @@ const usb_device_configuration_descriptor_t usb_configuration_descriptor = {
         .bFunctionLength        = sizeof(usb_configuration_descriptor.cdc_acm_2),
         .bDescriptorType        = usb_descriptor_type_cs_interface,
         .bDescriptorSubType     = usb_descriptor_subtype_cdc_acm,
-        .bmCapabilities         = 0,
+        .bmCapabilities         = USB_CDC_ACM_CAPABILITIES,
     },
     .cdc_union_2 = {
         .bFunctionLength        = sizeof(usb_configuration_descriptor.cdc_union_2),