Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer error signal emission in MssqlResult until done token is processed #49

Closed
mp911de opened this issue Mar 28, 2019 · 0 comments
Closed

Defer error signal emission in MssqlResult until done token is processed #49

mp911de opened this issue Mar 28, 2019 · 0 comments
Labels
type: bug Something isn't working
Milestone
0.8.0.M8

Comments

@mp911de
Copy link
Member

mp911de commented Mar 28, 2019

Error signals in MssqlResult are emitted directly and this causes cancellation of the upstream subscription. Frames may remain on the upstream source and this breaks downstream/next consumers.

We should defer error emission until receiving a done token and emit the error signal if an error was recorded.
@mp911de mp911de added the type: bug Something isn't working label Mar 28, 2019
@mp911de mp911de added this to the 1.0.0.M8 milestone Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
0.8.0.M8
Development

No branches or pull requests
1 participant
@mp911de