Feature/checkstyle #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adds an changes |
|
Please, can you checks this new changes? thanks. |
|
Sorry I can't man |
|
it's okay :( |
r3back
requested changes
Sep 10, 2023
| }), 0, 20); | ||
| private void whenStart() { | ||
| Bukkit.getScheduler().runTaskTimer(this, () -> Bukkit.getServer().getOnlinePlayers(). | ||
| forEach(player -> { |
There was a problem hiding this comment.
Cuando separas tenes que bajar el punto también, te quedaría .forEach en la línea de abajo
| * Makes an auctions service | ||
| * | ||
| * @return {@link AuctionService} | ||
| */ |
There was a problem hiding this comment.
En este caso más que un Makes quedaría mejor un Retrieves
| UserService service(); | ||
| Plugin plugin(); | ||
| /** | ||
| * Makes a config files |
| @@ -17,8 +20,21 @@ public final class AuctionCategory extends OkaeriConfig { | |||
| private GUIDisplayItem displayInfo; | |||
| private List<CategoryFilter> filters; | |||
|
|
|||
| /** | |||
| * Makes an auction category | |||
There was a problem hiding this comment.
En este caso no iría el makes porque es el constructor, reemplaza el esa línea por Default Constructor
| * | ||
| * @param id Id | ||
| * @param displayName Display Name | ||
| * @param materials {@link XMaterial} |
| * @param displayName Display Name | ||
| * @param materials {@link XMaterial} | ||
| * @param displayInfo {@link GUIDisplayItem} | ||
| * @param filters {@link CategoryFilter} |
| import lombok.Builder; | ||
| import lombok.Getter; | ||
|
|
||
| /** | ||
| * Utility class dor category filter |
| @Getter | ||
| public final class CategoryFilter extends OkaeriConfig { | ||
| /** | ||
| * Adds filter type |
| private final FilterType type; | ||
| private final String nbtKey; | ||
|
|
||
| /** | ||
| * Represents a filter type |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.