Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ergonomic macros instead of equivalent structs #14

Closed
nazmulidris opened this issue Aug 18, 2022 · 0 comments
Closed

Use ergonomic macros instead of equivalent structs #14

nazmulidris opened this issue Aug 18, 2022 · 0 comments
Assignees
@shayes12111
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nazmulidris
Copy link
Member

nazmulidris commented Aug 18, 2022 •
edited

Replace the use of the following structs w/ the following macros (which are more readable & easier for developers to use, ie, more ergonomic):

Struct Macro
Keypress keypress!
Size size!
Position position!
Pair pair!
@nazmulidris nazmulidris added the enhancement New feature or request label Aug 18, 2022
@nazmulidris nazmulidris changed the title Use keypress! macro instead of KeyPress struct Use ergonomic macros instead of equivalent structs Aug 19, 2022
@nazmulidris nazmulidris added the good first issue Good for newcomers label Aug 19, 2022
@nazmulidris nazmulidris mentioned this issue Aug 19, 2022
Closed
shayes12111 added a commit to shayes12111/r3bl_rs_utils that referenced this issue Aug 20, 2022
@shayes12111
Replace Size with size!
270749c 
Related to: Use ergonomic macros instead of equivalent structs r3bl-org#14
@shayes12111 shayes12111 mentioned this issue Aug 20, 2022
Merged
nazmulidris pushed a commit that referenced this issue Aug 20, 2022
@shayes12111 @nazmulidris
Replace Size with size!
32b23bc 
Related to: Use ergonomic macros instead of equivalent structs #14
nazmulidris added a commit that referenced this issue Aug 21, 2022
@nazmulidris
Replace Size with size!
d169593 
Related to: Use ergonomic macros instead of equivalent structs #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shayes12111 shayes12111

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nazmulidris @shayes12111