Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create reusable editor component #23

Closed
nazmulidris opened this issue Aug 12, 2022 · 1 comment
Closed

Create reusable editor component #23

nazmulidris opened this issue Aug 12, 2022 · 1 comment

Comments

@nazmulidris
Copy link
Member

nazmulidris commented Aug 12, 2022 •
edited

馃搶 The latest version of this design doc is in the repo here
@nazmulidris nazmulidris added the enhancement New feature or request label Aug 12, 2022
@nazmulidris nazmulidris changed the title Create editor component Create editor component (design document) Aug 14, 2022
@nazmulidris nazmulidris changed the title Create editor component (design document) Create editor component Aug 14, 2022
@nazmulidris nazmulidris added the dd label Aug 14, 2022
@nazmulidris nazmulidris transferred this issue from another repository Aug 29, 2022
@nazmulidris nazmulidris changed the title Create editor component Create reusable editor component Aug 29, 2022
nazmulidris added a commit that referenced this issue Aug 31, 2022
@nazmulidris
Add EditorEngine & EditorBuffer stubs
54ff026 
Stub out the implementation of the editor engine. The editor still
needs to be built (and when that commit lands it will close issue #23).

Related to #23

However, this allows integration w/ the editor component in r3bl-cmdr here:
r3bl-org/r3bl-cmdr@d1f7d7f
nazmulidris added a commit that referenced this issue Aug 31, 2022
@nazmulidris
Add EditorEngine & EditorBuffer skeleton
6dea59b 
Stub out the implementation of the editor engine. The editor still
needs to be built (and when that commit lands it will close issue #23).

Related to #23

However, this allows integration w/ the editor component in r3bl-cmdr here:
r3bl-org/r3bl-cmdr@d1f7d7f
@nazmulidris
Copy link
Member Author

nazmulidris commented Aug 31, 2022 •
edited

Add lolcat to EditorBuffer in this commit 3bc1d2d:

  • There are use cases where an editor buffer might need to have a re-usable color wheel for rainbow color effects

nazmulidris added a commit that referenced this issue Aug 31, 2022
@nazmulidris
Refactor EditorComponent
8d515d2 
Make lolcat instance available to each editor buffer. This ensures
that colorization can happen using the same "color wheel" to get
gradients that are related to each other (each step to the next
color is strongly related to the previous).

Add serde support, and related to it, f64 comparison support for
Lolcat.

Related to #23
nazmulidris added a commit that referenced this issue Aug 31, 2022
@nazmulidris
Refactor EditorComponent
8cd1dd6 
Make lolcat instance available to each editor buffer. This ensures
that colorization can happen using the same "color wheel" to get
gradients that are related to each other (each step to the next
color is strongly related to the previous).

Add serde support, and related to it, f64 comparison support for
Lolcat.

Related to #23
nazmulidris added a commit that referenced this issue Aug 31, 2022
@nazmulidris
Refactor EditorComponent
20f2719 
Make lolcat instance available to each editor buffer. This ensures
that colorization can happen using the same "color wheel" to get
gradients that are related to each other (each step to the next
color is strongly related to the previous).

Add serde support, and related to it, f64 comparison support for
Lolcat.

Related to #23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
e724989 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
e88a771 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
9bbf1aa 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
64bee88 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
2608476 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
e37bc92 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
b772516 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
0c8cbac 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
f5c586f 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 2, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
ac3ae71 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 3, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
b2f69c9 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 3, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
bd19599 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
#23
nazmulidris added a commit that referenced this issue Sep 3, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
c266d0f 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
- #23
- #30
nazmulidris added a commit that referenced this issue Sep 3, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
43bc237 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
- #23
- #30
nazmulidris added a commit that referenced this issue Sep 3, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
1407d88 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
- #23
- #30
nazmulidris added a commit that referenced this issue Sep 3, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
cf1b1d7 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
- #23
- #30
nazmulidris added a commit that referenced this issue Sep 3, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
dae5aca 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
- #23
- #30
nazmulidris added a commit that referenced this issue Sep 3, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
dd77b90 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros

Here's the design doc for this feature:
- #23
- #30
nazmulidris added a commit that referenced this issue Sep 3, 2022
@nazmulidris
WIP editor_engine.rs and editor_buffer.rs
0e408ba 
Caret
  - Add TWCommand to show & set caret (GlobalCursor)
  - Add support for LocalPaintedEffect caret
TWCommandQueue
  - add macro to make it easy to join and drop other queues into one
Position
  - add methods to check for bounds when adding rows and cols
Unicode
  - Vec<GraphemeClusterSegment> to / from String
Debug
  - Add GetSize derive macro for various structs
Testing
  - Add tests for editor buffer & engine
  - No such thing as visible for testing in integration tests
Ergonomics
  - Add better macro for debug: call_if_debug_true!
Documentation
  - Better code examples for macros
  - Add design doc for editor component

Here's the design doc for this feature:
- #23
- #30
@nazmulidris nazmulidris removed the enhancement New feature or request label Sep 19, 2022
@nazmulidris nazmulidris mentioned this issue Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nazmulidris