Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sftp compatibility? #6

Closed
JayWood opened this issue Aug 1, 2017 · 9 comments
Closed

sftp compatibility? #6

JayWood opened this issue Aug 1, 2017 · 9 comments

Comments

@JayWood
Copy link

JayWood commented Aug 1, 2017

Just a question really. The readme doesn't make any mention of sftp; can someone confirm rather or not sftp works with this?

@r3c
Copy link
Owner

r3c commented Aug 1, 2017

Hello, sftp is not currently supported. Maybe ssh would be a valid option if you're deploying to a host accepting ssh connection, otherwise support for sftp should be fairly easy to implement thanks to pysftp.

@JayWood
Copy link
Author

JayWood commented Aug 1, 2017

Problem I've faced is large hosting companies like WPEngine, don't support SSH, but require SFTP. I've resorted to handling all of our syncing requirements in bash so far, so I'll continue watching this for future developments.

Right now we're using a Jenkins setup, and require incremental deploys, and go figure, there's no one solution to that, but your application seems to fit the bill so far, just need sftp.

@r3c
Copy link
Owner

r3c commented Aug 1, 2017

Got it :) I'll probably be unable to implement this in the next coming weeks but I'll remember to ping you when/if I do it!

@lprimak
Copy link

lprimak commented Jun 2, 2021

Looks like ftplib supports FTP/TLS now. https://docs.python.org/3/library/ftplib.html
Can you implement this? Seems brain dead simple now.

@r3c
Copy link
Owner

r3c commented Jun 2, 2021

The doc you linked seems to be about FTP/TLS aka FTPs, which is a different protocol than sFTP. Am I missing something?

@lprimak
Copy link

lprimak commented Jun 2, 2021

Oh yes, I am talking about FTPes, not SFTP :) Should I open a new issue?

r3c added a commit that referenced this issue Jun 3, 2021
@r3c
Copy link
Owner

r3c commented Jun 3, 2021

No it's fine 🙂

I just pushed some code to support FTP+TLS on develop branch, would you mind having a try with your FTP server and tell me if it's OK for you? (I just did on my side but I only have access to one FTP server with TLS support enabled).

@lprimak
Copy link

lprimak commented Jun 5, 2021

That works great, thank you!

@r3c
Copy link
Owner

r3c commented Jun 5, 2021

Glad to hear that, you're very welcome 🙂

@r3c r3c closed this as completed Jun 5, 2021
r3c added a commit that referenced this issue Jun 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants