Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just update to Flux.jl 0.14 without breakage, keeping CUDA as a strong dep #88

Merged
merged 10 commits into from
Jul 17, 2023

Conversation

IanButterworth
Copy link
Collaborator

@IanButterworth IanButterworth commented Jul 17, 2023

  • Update to Flux.jl 0.14 without breakage here, keeping CUDA as a strong dep
  • Add a use_gpu=true model kwarg to allow the user to opt out of using Flux.gpu which now warns if a gpu isn't available
  • Move to a PrecompileTools based precompilation approach which is more robust. This avoids downloading weights files (200MB) by loading dummy data. But the conv modelling isn't fully precompiled due to the dummy data
┌ Warning: No valid algorithm found, probably bad params for convolution.
└ @ cuDNN ~/.julia/packages/cuDNN/YkZhm/src/convolution.jl:280

On GPU this fails, so gpu is turned off for precompilation.

@IanButterworth
Copy link
Collaborator Author

Nightly failures are JuliaArrays/StaticArrays.jl#1182

end
v2_608_COCO(;batch=1, silent=false, cfgchanges=nothing) = v2_COCO(w=608, h=608, batch=batch, silent=silent, cfgchanges=cfgchanges)
v2_608_COCO(;cfgchanges=nothing, kwargs...) = v2_COCO(;w=608, h=608, cfgchanges, kwargs...)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cfgchanges=nothing is a bug (that exists on master) as it prevents the v2_COCO method from setting the cfgchanges in response to w and h values, but it should be fixed in a breaking change PR as it changes the bounding box locations

@IanButterworth IanButterworth merged commit 64f45f2 into master Jul 17, 2023
6 of 9 checks passed
@IanButterworth IanButterworth deleted the ib/just_up_flux branch July 17, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant