SS_readdat_3.30

[kellijohnson-NOAA]

There are two objects, agebin_vector and sizefreq_bins_list, that have no visible binding in SS_readdat_3.30. Both of these are referenced prior to their use without binding as being part of the object d. Did the d$ just forget to be carried over to subsequent lines?

[iantaylor-NOAA]

I'm sure the d$ was just forgotten. Thanks for catching this.

SS_readdat_3.30 was developed by @cgrandin who kindly took on the task by modifying SS_readdat_3.24. However, I'm sure it hasn't been tested on, and probably doesn't work for, any model that uses the generalized size frequency data option which is where sizefreq_bins_list comes in. I'm not sure how it worked for a model that used age data for which agebin_vector would have played a role.

[kellijohnson-NOAA]

Probably had `agebin_vector` in their workspace while they were testing it. I have done similar things in the past many times. Always a good practice to close `R` and test everything in a new session before committing.

…

On Thu, Apr 6, 2017 at 1:10 PM, Ian Taylor ***@***.***> wrote: I'm sure the d$ was just forgotten. Thanks for catching this. SS_readdat_3.30 was developed by @cgrandin <https://github.com/cgrandin> who kindly took on the task by modifying SS_readdat_3.24. However, I'm sure it hasn't been tested on, and probably doesn't work for, any model that uses the generalized size frequency data option which is where sizefreq_bins_list comes in. I'm not sure how it worked for a model that used age data for which agebin_vector would have played a role. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#140 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD6xFEnrAnMqfLIEWfO4BklT0V7lnDyuks5rtUargaJpZM4M2FY7> .

-- Kelli Faye Johnson kellifayejohnson@gmail.com

[cgrandin]

Ian is correct, I missed the d$. I only tested for the options used in the hake assessment, and just pasted the rest in for convenience (we were short on time). Thanks for fixing it.

[iantaylor-NOAA]

Closing old issue that was sorted out some time ago.