Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate 3.24 functions #718

Merged
merged 4 commits into from Jul 20, 2022
Merged

Deprecate 3.24 functions #718

merged 4 commits into from Jul 20, 2022

Conversation

k-doering-NOAA
Copy link
Contributor

Resolves #702 by deprecating read and write functions related to 3.24.

Copy link
Contributor

@iantaylor-NOAA iantaylor-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you @k-doering-NOAA.
This resolves issue #702.

Can you also push a change to DESCRIPTION to bump the version number to 1.45.3 so folks start getting the message right away?

R/SS_changepars.R Show resolved Hide resolved
@k-doering-NOAA
Copy link
Contributor Author

Thanks for reminding me to bump the version in the DESCRIPTION file. I'll let the github actions finish and then will merge this in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecate functions relating to 3.24 and older models
2 participants