Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a function download_models to download ss3 test models #721

Merged
merged 5 commits into from
Jul 29, 2022
Merged

Create a function download_models to download ss3 test models #721

merged 5 commits into from
Jul 29, 2022

Commits on Jul 21, 2022

  1. feat, #574: create download_models() to download the ss3 test models … 

    …directory.
    @k-doering-NOAA
    k-doering-NOAA committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    793db5b View commit details
    Browse the repository at this point in the history

  2. add utils:: in front of instances of unzip to rm warning

    @k-doering-NOAA
    k-doering-NOAA committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    e1c829c View commit details
    Browse the repository at this point in the history

  3. fix: comment out a test 

    This test would fail if the super_test feature branch is removed from the test-models repo, so it seems wise to not include it. However, it was a nice local test to make sure the function worked as I expected when setting it up!
    @k-doering-NOAA
    k-doering-NOAA committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    424e88d View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. fix: documentation wording, create folders, changes tests 

    suggestions from @kellijohnson-NOAA in PR #721
    @k-doering-NOAA
    k-doering-NOAA committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    2566798 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. fix: more changes proposed by @kellijohnson-NOAA 

    including running devtools::spell_check() devtools::document() and styler::style_file() for the files related to download_models
    @k-doering-NOAA
    k-doering-NOAA committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    f409bae View commit details
    Browse the repository at this point in the history