Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove revocation_time/revocation_reason on unrevoke #10

Open
reaperhulk opened this issue Jun 12, 2013 · 0 comments
Open

Remove revocation_time/revocation_reason on unrevoke #10

reaperhulk opened this issue Jun 12, 2013 · 0 comments

Comments

@reaperhulk
Copy link
Member

Got this from a user:

"Not sure if R509::Validity::Redis::Writer should remove "revocation_time" and "revocation_reason" key on unrevoke. At least it should remove the values, what do you think?"

I can't remember if we had a good reason for leaving that data present when unrevoking a certificate? Was it to keep a record that the certificate had been revoked in the past? If you revoke the certificate again these fields are overwritten with new values, so they're really just dangling in the data store.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant