New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for tag 0 in asn #128

Closed

chrismccaw wants to merge 1 commit into r509:master from onelogin:tag-0-asn

chrismccaw commented Oct 16, 2019 •

edited

Need this for certain certificates

An example certificate to test this against

-----BEGIN CERTIFICATE-----
MIIF9TCCBN2gAwIBAgITWgAAALmAloKnk9H4+gAAAAAAuTANBgkqhkiG9w0BAQsF
ADBPMRMwEQYKCZImiZPyLGQBGRYDT0ZGMRQwEgYKCZImiZPyLGQBGRYETUNBUDEi
MCAGA1UEAxMZTWF2ZXJpY2tjYXAtSXNzdWluZy1DQS0wMTAeFw0xOTA5MTMxODM2
NThaFw0yNDA5MTExODM2NThaMIG5MRMwEQYKCZImiZPyLGQBGRYDT0ZGMRQwEgYK
CZImiZPyLGQBGRYETUNBUDEWMBQGA1UECwwNVXNlcl9BY2NvdW50czESMBAGA1UE
CxMJTWF2ZXJpY2tzMQwwCgYDVQQLEwNNSVMxEDAOBgNVBAsTB1N1cHBvcnQxFDAS
BgNVBAMTC0tlbm55IFN0ZXJuMSowKAYJKoZIhvcNAQkBFhtLZW5ueS5TdGVybkBt
YXZlcmlja2NhcC5jb20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC8
4RzhAjeK4XGXvAgl/ShTz6KNG6z+FnEQKxvWvs/vRc0+wSjx5bABK/+aHOMyTU7R
NUmTZA9Kx0387NhpFsQkSWcOwysYYGjLQG0xsh7ZeyLKtEhRyzDFOzpmloQKjBSx
8bYYBdYGXovL3zTtvGhG3se8mJVNIoSvTLF6LfzO6ZnjP98Kw/nPovPcn9HONQLN
FBBU9O0xNCnCZbUBdhDW2Ee4NaoMwvzql2djEfrprNZGsrrC8l+oWr3bvKyyTAiX
Uc+qlHMehkMnxCXXZ1GDONA9jNJRpkSN9QwWlIAr37yEcYYYAh318y0IJYdoBBIh
7jAl20J1/DsA5hnj8fGhAgMBAAGjggJdMIICWTALBgNVHQ8EBAMCBaAwPQYJKwYB
BAGCNxUHBDAwLgYmKwYBBAGCNxUIhvvPMoT10juH1YMlgf/DVoSG0h8vhdeOf4G5
wRYCAWQCAQQwRAYJKoZIhvcNAQkPBDcwNTAOBggqhkiG9w0DAgICAIAwDgYIKoZI
hvcNAwQCAgCAMAcGBSsOAwIHMAoGCCqGSIb3DQMHMB0GA1UdDgQWBBRdfH+7KeOi
jbezeY/dMBIH26yW7DAfBgNVHSMEGDAWgBT957R+3tVJvl/wzY9ofpV+bCGgZjBU
BgNVHR8ETTBLMEmgR6BFhkNodHRwOi8vcGtpLm1hdmVyaWNrY2FwLmNvbS9DZXJ0
RW5yb2xsL01hdmVyaWNrY2FwLUlzc3VpbmctQ0EtMDEuY3JsMHgGCCsGAQUFBwEB
BGwwajBoBggrBgEFBQcwAoZcaHR0cDovL3BraS5tYXZlcmlja2NhcC5jb20vQ2Vy
dEVucm9sbC9BRENTLUNBMDEtVFgtUFIuTUNBUC5PRkZfTWF2ZXJpY2tjYXAtSXNz
dWluZy1DQS0wMS5jcnQwKQYDVR0lBCIwIAYIKwYBBQUHAwIGCCsGAQUFBwMEBgor
BgEEAYI3CgMEMDUGCSsGAQQBgjcVCgQoMCYwCgYIKwYBBQUHAwIwCgYIKwYBBQUH
AwQwDAYKKwYBBAGCNwoDBDBTBgNVHREETDBKoCsGCisGAQQBgjcUAgOgHQwbS2Vu
bnkuU3Rlcm5AbWF2ZXJpY2tjYXAuY29tgRtLZW5ueS5TdGVybkBtYXZlcmlja2Nh
cC5jb20wDQYJKoZIhvcNAQELBQADggEBADWUlF6wxARCt/PI9mFd72GmHDjIgxjD
ej4N1gc0SvOkDGynQRk7xsv641n8PMlsuHm+BlZDs6XmiJF5FWPfw//umff+Xdkd
xLAjb4V7vQiQFIcMsPbIgSSObmbVvwTfLP66U85u/4oDYezJu925lX9LFLcpzLu8
4XxKfBsdOQJ3jUaWgC6pCzjf4KEv6QcY3xk6+fNeLLmI+0eO0oDp+X7ZwoFvnoWt
CgNodjA1Mm78oGkSAgHK06BZHyjrWKBkYy87ZRWZJzbZrWYVjBcQIhoFq35QhpYR
17+/4dotNkdhI46/V2HSJ79FBTB7QfQZAvcZY2UKnJPDb7Hf+yHV1RY=
-----END CERTIFICATE-----


          Add support for tag 0 in asn

265fffa

coveralls commented Oct 16, 2019

Coverage increased (+0.01%) to 99.721% when pulling 265fffa on onelogin:tag-0-asn into 05aaeb1 on r509:master.

Member

reaperhulk commented Oct 16, 2019

Looks like the test failures are likely relevant

chrismccaw closed this

chrismccaw deleted the tag-0-asn branch

November 2, 2019 00:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment