Dev #20
Draft
Dev #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
r52
commented
Apr 13, 2024
•
r52
commented
- Riverpod 3 upgrade/support
- Related manga view
- MDList support
- MD OAuth based authentication
- Basic Local Library sorting options
- Better long strip/to to bottom reader
- Material 3 styling
- Various fixes
- Various optimizations
- Various QoL improvements
- ...and much more
- Also changed status picker to dropdown for better future support when the MD API changes to a fully CustomList based system
- Reimplements manga view in NestedScrollView to support nested MangaListView
Try blocking PageView swipe gestures if the page image isn't at initial size. This also disallows swiping at image edges, but is a better compromise than not being able to pan at all after zooming due to gesture fighting.
Try to stop deeplink loop when deeplinks are enabled
Allows MangaListWidget to be created with no implicit/default scroll controller so that it can collapse into parent NestedScrollViews
Also cache empty results to prevent requerying
Supports: - Adding/removing manga from existing lists - Creating new lists Also adds rating button text
- Personal client only - Removes deprecated login API
As per doc
Couldn't input anything due to rebuild being triggered repeatedly
- Removes the rest of hardcoded colours - Fixed some components legibility on light theme
- Changed forum icon - Fix manga status chip regression - Consolidate some code
Use a Listener to keep track of pointer events to workaround PageView's gesture fighting with a child interactive image viewer widget until this gets fixed in flutter natively
- Keep alive so that scrolling up fast doesn't reload - Use BoxConstraint to keep width in check, rather than relying on scaling multiples - Forgo builder (and add a large cache) for smoother scrolling
This reverts commit 06dbbf9.
Takes advantage of the fact that the md/cb servers still redirect http to https to workaround the fact that url_launcher doesn't work/in-app browser mode isn't respected or is ignored/preempted when deeplinks are enabled on those domains, and gagaku only registers https as the scheme. Not a good long term solution and needs to be amended when there is a proper fix.
For local library
For potentially smoother scrolling
Cleans up all the rebuilds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.