Fix a bug of updating Build#incremental_id

r7kamura · Jul 24, 2013 · c6e4aac · c6e4aac
1 parent 00d7add
commit c6e4aac
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/app/models/build.rb b/app/models/build.rb
@@ -75,7 +75,7 @@ def finish(result)
   end
 
   def update_incremental_id
-    update_attributes(incremental_id: job.builds_count)
+    update_attributes(incremental_id: job.builds.count)
   end
 
   private

diff --git a/spec/models/build_spec.rb b/spec/models/build_spec.rb
@@ -16,6 +16,7 @@
         build.started_at.should be_present
         build.finished_at.should be_present
         build.status.should == true
+        build.incremental_id.should_not be_nil
       end
     end
 
@@ -29,6 +30,7 @@
         build.started_at.should be_present
         build.finished_at.should be_present
         build.status.should == false
+        build.incremental_id.should_not be_nil
       end
     end
   end