Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor methor visibilities #183

Merged
merged 1 commit into from Jun 4, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -33,6 +33,28 @@ class RailsUniquenessValidatorExplicitCaseSensitivity < Base

RESTRICT_ON_SEND = %i[validates].freeze

# @param [RuboCop::AST::SendNode] node
def on_send(node)
return unless validates_uniqueness?(node) && !validates_uniqueness_with_case_sensitivity?(node)

uniqueness_value = find_uniqueness_value(node)
add_offense(uniqueness_value) do |corrector|
if uniqueness_value.true_type?
corrector.replace(
uniqueness_value,
'{ case_sensitive: true }'
)
else
corrector.insert_after(
uniqueness_value.pairs.last,
', case_sensitive: true'
)
end
end
end

private

# @!method validates_uniqueness?(node)
def_node_matcher :validates_uniqueness?, <<~PATTERN
(send nil? :validates
Expand Down Expand Up @@ -69,26 +91,6 @@ class RailsUniquenessValidatorExplicitCaseSensitivity < Base
def find_uniqueness_value(node)
node.arguments[1].pairs.find { |pair| pair.key.value == :uniqueness }.value
end

# @param [RuboCop::AST::SendNode] node
def on_send(node)
return unless validates_uniqueness?(node) && !validates_uniqueness_with_case_sensitivity?(node)

uniqueness_value = find_uniqueness_value(node)
add_offense(uniqueness_value) do |corrector|
if uniqueness_value.true_type?
corrector.replace(
uniqueness_value,
'{ case_sensitive: true }'
)
else
corrector.insert_after(
uniqueness_value.pairs.last,
', case_sensitive: true'
)
end
end
end
end
end
end
Expand Down